reject out-of-range decimal64 precision in sanitizeGNMI - #1099
Open
nabhan06 wants to merge 1 commit into
Open
Conversation
|
coverage: 88.745% (+0.002%) from 88.743% — nabhan06:decimal64-precision-bound into openconfig:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitizeGNMI decodes a gNMI Decimal64 by raising 10 to the power of Precision, a uint32 read straight from the untrusted value with no upper bound. A YANG decimal64 has at most 18 fraction digits, so a message that sets a decimal64 leaf with a large Precision makes big.Int.Exp build a multi-gigabyte integer (Precision=20,000,000 already costs 2.3s and 227MB, and the uint32 max is far worse). Reject any Precision above 18 before the exponentiation, matching the nil check already right above it.