feat: support for diffing presence containers - #990
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4970f67 to
519ff68
Compare
|
Hello @wenovus and @robshakir - it took some time, but we finally managed to crack the code. Please review. 😊 |
519ff68 to
58943fa
Compare
58943fa to
8c252eb
Compare
|
Also tagging #645 author, @hansthienpondt. |
|
Hi @robshakir , friendly bump in case you missed this 😊 |
|
I did miss it -- apologies, let me review ASAP. |
No worries, @robshakir! We’ve been using the fork in production and it’s worked like a charm. |
|
@robshakir, would love to get this looked at. 😊 |
|
@JonasKs holy-moly! apologies! this one passed me by. reviewing now. 🔎 |
|
Thanks so much, @robshakir! I’m out of office for ~2 weeks, but I’ll address all comments when I’m back! |
Co-authored-by: Terje Lafton <terje@lafton.io>
Co-authored-by: Terje Lafton <terje@lafton.io>
Co-authored-by: Terje Lafton <terje@lafton.io>
32d9ebd to
ea3585f
Compare
|
Hey @robshakir, sorry for never following up here. I no longer work at Intility, but I got a call from a good old colleague @luancvt, who still needs this merged upstream. I've addressed the comments here, and would appreciate if you could do another review? I've given @luancvt write access to my fork, so he can follow up any feedback you might have. Seems like pipelines fail in |
Closes #936.
The implementation ended up being somewhat as described in #936, where we indicate that presence container has a
nilvalue in thefindSetLeavesfunction.In addition to this, we added a presence container interface, which is used in the
marshalStructOrOrderedListto isolate the presence container which might have values, to act like an empty struct.The result is that we do not break any current tests (even without the diff option), but we decided to add a diff option, with the reasoning described in #936:
We've confirmed this works in our setup. We're able to successfully configure all presence containers, even nested ones.
Co-authored-by: Terje Lafton terje@lafton.io