Skip to content

Fixes to minres #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peastman merged 1 commit into from
Aug 25, 2026
Merged

Fixes to minres #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions mlipops/minres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,27 +147,25 @@ def minres(A, b, M=None, x0=None, tol=1e-5, maxiters=None):
if ynorm.max() == 0 or Anorm == 0:
test1 = torch.inf
else:
test1 = rnorm / (Anorm * ynorm)

test1 = (rnorm / (Anorm * ynorm)).max()
if test1 <= tol:
break
if Anorm == 0:
test2 = torch.inf
else:
test2 = root / Anorm
Acond = gmax / gmin
t1 = 1 + test1.max()
t2 = 1 + test2.max()
if t2 <= 1:
test2 = (root / Anorm).max()
if test2 <= tol:
break
if t1 <= 1:
break

if Acond >= 0.1 / eps:
assert False, "System is ill-conditioned."
if (epsx >= beta1).any():
assert False
if test2.max() <= tol:
Acond = gmax / gmin
if Acond >= 0.1 / eps:
assert False, "System is ill-conditioned."
t1 = 1 + test1
if t1 <= 1:
break
if test1.max() <= tol:
t2 = 1 + test2
if t2 <= 1:
break
return x

Expand Down
Loading