service: live-write push catalog without waiting for demand - #9
Open
BufferStarved wants to merge 1 commit into
Open
service: live-write push catalog without waiting for demand#9BufferStarved wants to merge 1 commit into
BufferStarved wants to merge 1 commit into
Conversation
publish_tracks is supposed to put the initial catalog on the wire so a catalog-blind relay can cache it. Retained-group install is the FETCH path; gating the live write on sender_track_demand skipped it when PUBLISH_OK arrived with Forward 0. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Hey, can you provide the failing wire sequence that motivated this change? Specifically, did the subscriber issue a joining fetch, and did the relay move the upstream publication from forward 0 to forward 1? We can't assume the relay will retain the catalog because at the transport layer it is just another track. |
BufferStarved
added a commit
to BufferStarved/MoQ-Test-Tools
that referenced
this pull request
Aug 26, 2026
…ite catalogs. openmoq/moq5#9 is still open, so the demand-gate removal stays a local patch. Leftover :4433 stays on 329b98b. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publish_tracksis supposed to write the initial catalog so a catalog-blind relay can cache it. That is not the same as installing the retained group (SUBSCRIBE + Joining FETCH still reads the origin cache).The live write was gated on
sender_track_demand.PUBLISH_OKoften has Forward 0, so group 0 never left the origin.Does not replay retained objects onto a plain SUBSCRIBE.
Verified: draft-18 moqx + playa CatalogBootstrap, headed CMAF painted.
Test
test_media_sender_push_cursorstill sees generation 0publish_tracks = falseunchangedThis change is