relay: defer CrossExecFilter destruction to its target executor - #654
Open
afrind wants to merge 1 commit into
Open
relay: defer CrossExecFilter destruction to its target executor#654afrind wants to merge 1 commit into
afrind wants to merge 1 commit into
Conversation
CrossExecFilter's methods enqueue [this]-capturing lambdas on targetExec_, but nothing keeps the filter alive until they run — owners release it from whatever executor they happen to be on. It can be freed with calls still queued, and the lambda then reads downstream_ off freed memory, seen as a SIGSEGV in beginSubgroup on a v0.3.1 relay. The sibling filters anchor themselves with selfGuard_, but that needs a terminal call and a TrackConsumer has none that is guaranteed. Destruction is guaranteed, so create() installs a deleter that posts the delete to targetExec_ behind every lambda already queued, and PrivateTag makes create() the only way to build one. auto filter = CrossExecFilter::create(targetExec, downstream); Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrossExecFilter's methods enqueue [this]-capturing lambdas on targetExec_, but nothing keeps the filter alive until they run — owners release it from whatever executor they happen to be on. It can be freed with calls still queued, and the lambda then reads downstream_ off freed memory, seen as a SIGSEGV in beginSubgroup on a v0.3.1 relay.
The sibling filters anchor themselves with selfGuard_, but that needs a terminal call and a TrackConsumer has none that is guaranteed. Destruction is guaranteed, so create() installs a deleter that posts the delete to targetExec_ behind every lambda already queued, and PrivateTag makes create() the only way to build one.
This change is