build: lint and format the repo's Python with ruff - #655
Open
afrind wants to merge 1 commit into
Open
Conversation
Nothing formats or lints the Python in tools/, scripts/perf/ and docker/ — check-format covers C++ only. ruff.toml configures it, with target-version py39 so pyupgrade holds to the oldest interpreter contributors already have, and an explicit rule list so a ruff upgrade cannot switch on rules nobody chose. scripts/dev/format.sh now runs ruff beside clang-format and pins its version the same way; uv fetches the pin, and check-format installs uv. Reformats the three existing scripts and fixes what the lint found: two unused locals, three percent-format strings and an unsorted import block. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing formats or lints the Python in tools/, scripts/perf/ and docker/ — check-format covers C++ only. ruff.toml configures it, with target-version py39 so pyupgrade holds to the oldest interpreter contributors already have, and an explicit rule list so a ruff upgrade cannot switch on rules nobody chose.
scripts/dev/format.sh now runs ruff beside clang-format and pins its version the same way; uv fetches the pin, and check-format installs uv. Reformats the three existing scripts and fixes what the lint found: two unused locals, three percent-format strings and an unsorted import block.
This change is