OCPBUGS-84517: Remove stale openshift-marketplace terminationMessagePolicy exemption

[jrangelramos]

Summary

Remove the openshift-marketplace namespace exemption from the
terminationMessagePolicy monitor test.

Background

The monitor test [sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError was flaking
because osd-patch-subscription-source CronJob pods lacked
terminationMessagePolicy: FallbackToLogsOnError.

A temporary exemption was added, but it incorrectly exempted
pods/podman rather than the actual violating pods. The root cause has
been fixed upstream by adding terminationMessagePolicy: FallbackToLogsOnError to the CronJob containers.

Dependencies

This PR depends on the upstream fix:

• OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace Cronjobs managed-cluster-config#2800 — OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace Cronjobs

Bug: OCPBUGS-84517

Summary by CodeRabbit

• Bug Fixes
  • Tightened validation for termination message policy checks so a previously exempt namespace is no longer treated as an allowed exception.
  • Improved test coverage behavior by ensuring more violations are reported as failures instead of being ignored.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Remove the openshift-marketplace namespace exemption from the
terminationMessagePolicy monitor test.

Background

The monitor test [sig-arch] all containers in ns/openshift-marketplace must have terminationMessagePolicy=FallbackToLogsOnError was flaking
because osd-patch-subscription-source CronJob pods lacked
terminationMessagePolicy: FallbackToLogsOnError.

A temporary exemption was added, but it incorrectly exempted
pods/podman rather than the actual violating pods. The root cause has
been fixed upstream by adding terminationMessagePolicy: FallbackToLogsOnError to the CronJob containers.

Dependencies

This PR depends on the upstream fix:

• OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace Cronjobs managed-cluster-config#2800 — OCPBUGS-84517: Add terminationMessagePolicy to openshift-marketplace Cronjobs

Bug: OCPBUGS-84517

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fb14455c-a341-4758-a3fc-f86bf8a4f7be

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf37da and 9df098d.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

Removes the openshift-marketplace namespace entry from the existingViolations exception map in terminationMessagePolicyChecker.CollectData, so containers in that namespace are no longer grandfathered and will be treated as test failures instead of flakes.

Changes

Remove openshift-marketplace grandfathering exception

Layer / File(s)	Summary
Remove openshift-marketplace from existingViolations pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Deletes the openshift-marketplace entry from the existingViolations map; containers in that namespace will now fail the termination message policy check rather than being skipped as known violations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing the stale openshift-marketplace terminationMessagePolicy exemption.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jrangelramos]

/jira refresh

[openshift-ci-robot]

@jrangelramos: This pull request references Jira Issue OCPBUGS-84517, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.