refactor: organize layout utils - #291
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing image_layout breaks downstream imports; add a compatibility shim or document the breaking change.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Refactors preprocessor layout utilities into dedicated enum and utility modules.
Changes:
- Moves
ImageLayouttoenums.py. - Moves layout inference to
utils/layout_utils.py. - Updates imports and package exports.
| File | Summary |
|---|---|
src/physicalai/inference/preprocessors/utils/layout_utils.py |
Hosts layout inference; restore the standard license header. |
src/physicalai/inference/preprocessors/utils/__init__.py |
Adds the utilities package; restore the standard license header. |
src/physicalai/inference/preprocessors/smolvla.py |
Updates layout utility imports. |
src/physicalai/inference/preprocessors/resize.py |
Updates layout imports; preserve compatibility for the removed image_layout module. |
src/physicalai/inference/preprocessors/enums.py |
Defines ImageLayout. |
src/physicalai/inference/preprocessors/__init__.py |
Re-exports ImageLayout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
alfieroddan
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Breaking changes