fix: use PascalCase for dimensions and metrics in shell script#3
Open
SmallMouth wants to merge 1 commit into
Open
fix: use PascalCase for dimensions and metrics in shell script#3SmallMouth wants to merge 1 commit into
SmallMouth wants to merge 1 commit into
Conversation
The API requires PascalCase format for dimension and metric names. Changed: - hour → Hour - pageDomain → PageDomain - allRequests → AllRequests - clicks → Clicks
SmallMouth
marked this pull request as ready for review
January 20, 2026 06:36
|
This was the change OpenX support asked me to make in my local to fix the script, would be nice for this to be merged! |
|
This pull request has been inactive for an extended period and will be closed in 14 days if no activity occurs. To prevent closure, please:
Auto-generated by GitHub Cleaner - Notification 1/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shell script uses lowercase dimension and metric names which causes API error:
Invalid metric allRequests,Invalid dimension hourSolution
Changed to PascalCase format to match API requirements and README examples.
Changes
hour→HourpageDomain→PageDomainallRequests→AllRequestsclicks→ClicksReference