Publish TypeScript SDK documentation - #220
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.96
The documentation implementation is otherwise consistent with the unchanged SDK behavior, but both newly added contract verifiers accept concrete invalid inputs. Model-level verification is not recommended because this diff does not change runtime control semantics.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.97
The patch introduces two publication-admission bypasses and weakens both new and existing regression oracles. Runtime control semantics are otherwise unchanged, so model-level verification is not recommended before merge.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.94
The documentation build itself is consistent, but two newly changed regression oracles are unsound: one misses durable Git mutations and the other treats comments as active workflow configuration. Model-level verification is not recommended before merge; targeted negative tests are sufficient.
There was a problem hiding this comment.
Codex automated review
Verdict: patch is incorrect
Confidence: 0.98
The documentation changes appear consistent, but the modified regression oracle no longer enforces its stated no-mutation contract. Model-level verification is not recommended because executable control behavior was not changed.
Summary
Verification
npm run docs:checkpython3 -m unittest discover -s .github/tests -p 'test_*.py'(51 tests; one expected failure)python3 .github/scripts/run_go_tests.py(369 tests)GOWORK=off go vet ./...andGOWORK=off go build ./...docs:checkexit 3/tmp/boatstack-typescript-docs-home-current.png/tmp/boatstack-typescript-docs-mobile-current.pngBoundary conformance
Boundary: documentation source to required CI, Pages artifact, and deployment request.
Control law: a public SDK change must pass TypeScript and documentation validation; documentation publication cannot invoke or mutate the runtime release workflow.
Evidence: repository-contract tests bind the required CI command, both package inputs, main-only Pages trigger, official Pages action identities, minimum deployment permissions, and release independence. Rejection leaves runtime release state unchanged.
Residual risk: GitHub Pages is not enabled for this repository yet. After merge, a maintainer must select GitHub Actions as the Pages publishing source before the first deployment can complete.
Self-documenting API findings
anyandnot, but no public ergonomic helpers expose themfacetandevidenceaccept less descriptive metadata than their public definition typestrustedOperatorsandtrustedTransitions; that pairing is currently implicitRelease note:
release-notes/2026-08-15-typescript-sdk-documentation.md