Skip to content

Publish TypeScript SDK documentation - #220

Merged
bigboateng merged 4 commits into
mainfrom
docs/typescript-sdk-reference
Aug 15, 2026
Merged

Publish TypeScript SDK documentation#220
bigboateng merged 4 commits into
mainfrom
docs/typescript-sdk-reference

Conversation

@bigboateng

@bigboateng bigboateng commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • generate one TypeDoc site for both public TypeScript Flow packages, including five Product Delivery guides and an API reflection model
  • document public authoring, authority, delegation, target, entry, and diagnostics semantics in the TypeScript source
  • validate documentation in the required Flow SDK job and deploy main through an independent GitHub Pages workflow
  • enforce direct public-export, parsed-trigger, main-ref, and deployment-time documentation contracts
  • structurally validate executable workflow jobs, permissions, conditions, runs, and action uses
  • keep explain immutability snapshots scoped to repository files and stable Git semantics, including symbolic HEAD and index, instead of transient Git internals

Verification

  • npm run docs:check
  • python3 -m unittest discover -s .github/tests -p 'test_*.py' (51 tests; one expected failure)
  • python3 .github/scripts/run_go_tests.py (369 tests)
  • five focused explain and snapshot-boundary tests repeated 25 times on the current tree
  • GOWORK=off go vet ./... and GOWORK=off go build ./...
  • release-note validation and preflight
  • an injected broken guide link made docs:check exit 3
  • desktop render: /tmp/boatstack-typescript-docs-home-current.png
  • 390 x 844 API render: /tmp/boatstack-typescript-docs-mobile-current.png
  • both rendered surfaces had zero browser console warnings or errors

Boundary conformance

Boundary: documentation source to required CI, Pages artifact, and deployment request.

Control law: a public SDK change must pass TypeScript and documentation validation; documentation publication cannot invoke or mutate the runtime release workflow.

Evidence: repository-contract tests bind the required CI command, both package inputs, main-only Pages trigger, official Pages action identities, minimum deployment permissions, and release independence. Rejection leaves runtime release state unchanged.

Residual risk: GitHub Pages is not enabled for this repository yet. After merge, a maintainer must select GitHub Actions as the Pages publishing source before the first deployment can complete.

Self-documenting API findings

  • the predicate representation supports any and not, but no public ergonomic helpers expose them
  • facet and evidence accept less descriptive metadata than their public definition types
  • callers must pass the same lifecycle to trustedOperators and trustedTransitions; that pairing is currently implicit
  • entry diagnostics use an inline public shape rather than a named interface

Release note: release-notes/2026-08-15-typescript-sdk-documentation.md

@cursor

cursor Bot commented Aug 15, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is incorrect
Confidence: 0.96

The documentation implementation is otherwise consistent with the unchanged SDK behavior, but both newly added contract verifiers accept concrete invalid inputs. Model-level verification is not recommended because this diff does not change runtime control semantics.

Comment thread scripts/check-docs-api.mjs Outdated
Comment thread .github/tests/test_docs_contract.py Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is incorrect
Confidence: 0.97

The patch introduces two publication-admission bypasses and weakens both new and existing regression oracles. Runtime control semantics are otherwise unchanged, so model-level verification is not recommended before merge.

Comment thread .github/workflows/docs-pages.yml
Comment thread .github/workflows/docs-pages.yml Outdated
Comment thread scripts/check-docs-api.mjs Outdated
Comment thread boatstack/cmd/boatstack-helper/flow_runtime_test.go

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is incorrect
Confidence: 0.94

The documentation build itself is consistent, but two newly changed regression oracles are unsound: one misses durable Git mutations and the other treats comments as active workflow configuration. Model-level verification is not recommended before merge; targeted negative tests are sufficient.

Comment thread boatstack/cmd/boatstack-helper/flow_runtime_test.go
Comment thread .github/tests/test_docs_contract.py Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex automated review

Verdict: patch is incorrect
Confidence: 0.98

The documentation changes appear consistent, but the modified regression oracle no longer enforces its stated no-mutation contract. Model-level verification is not recommended because executable control behavior was not changed.

Comment thread boatstack/cmd/boatstack-helper/flow_runtime_test.go
@bigboateng
bigboateng enabled auto-merge (squash) August 15, 2026 05:31
@bigboateng
bigboateng merged commit 17e89ed into main Aug 15, 2026
18 checks passed
@bigboateng
bigboateng deleted the docs/typescript-sdk-reference branch August 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant