Skip to content

[AUTOWORK-205] Rename "CustomAction" to "Automations" namespace - #25163

Open
oliverguenther wants to merge 1 commit into
devfrom
feat/automations-namespace
Open

oliverguenther wants to merge 1 commit into
devfrom
feat/automations-namespace

Conversation

@oliverguenther

Copy link
Copy Markdown
Member

Converts all CustomAction references to automations, including tables and serialization. No functionality added, as automations will be created with a fixed trigger for "Manual button press"

https://community.openproject.org/work_packages/AUTOWORK-205

@oliverguenther oliverguenther changed the title Rename "CustomAction" to "Automations" namespace [AUTOWORK-205] Rename "CustomAction" to "Automations" namespace Sep 7, 2026
@github-actions

This comment was marked as resolved.

@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch 2 times, most recently from ea25fe2 to ce4d0ab Compare September 7, 2026 12:20
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25163, linked for reference only):

- `rspec ./modules/wikis/spec/features/admin/internal_provider_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #25163. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25163 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @oliverguenther to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @oliverguenther, and request a review from @oliverguenther.
On every commit, set @oliverguenther as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch 2 times, most recently from f7dc5ba to 30636c6 Compare September 8, 2026 06:38
@oliverguenther oliverguenther added this to the 18.0.x milestone Sep 8, 2026
@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch from 30636c6 to 32c9c11 Compare September 8, 2026 09:20
@oliverguenther
oliverguenther marked this pull request as ready for review September 8, 2026 09:21
@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch from a1f48af to 915aca3 Compare September 8, 2026 11:07
@klaustopher

Copy link
Copy Markdown
Contributor

I guess all files need the license header?

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/meeting/spec/features/presentation/meeting_presentation_mode_spec.rb[1:1]
  • rspec ./spec/features/projects/creation_wizard/project_creation_wizard_spec.rb[1:11:1]
  • rspec ./spec/features/projects/creation_wizard/wizard_from_template_flow_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25163, linked for reference only):

- `rspec ./modules/meeting/spec/features/presentation/meeting_presentation_mode_spec.rb[1:1]`
- `rspec ./spec/features/projects/creation_wizard/project_creation_wizard_spec.rb[1:11:1]`
- `rspec ./spec/features/projects/creation_wizard/wizard_from_template_flow_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #25163. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25163 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @oliverguenther to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @oliverguenther, and request a review from @oliverguenther.
On every commit, set @oliverguenther as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch from 404a67e to a8cbe56 Compare September 9, 2026 13:19
@oliverguenther

Copy link
Copy Markdown
Member Author

@klaustopher I went through all changed files and made sure the header is there

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:2:1]
  • rspec ./modules/meeting/spec/features/meeting_notifications_spec.rb[1:2:1]
  • rspec ./modules/meeting/spec/features/meeting_notifications_spec.rb[1:2:2]
  • rspec ./spec/features/workflows/edit_spec.rb[1:7:6]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25163, linked for reference only):

- `rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:2:1]`
- `rspec ./modules/meeting/spec/features/meeting_notifications_spec.rb[1:2:1]`
- `rspec ./modules/meeting/spec/features/meeting_notifications_spec.rb[1:2:2]`
- `rspec ./spec/features/workflows/edit_spec.rb[1:7:6]`

Treat this as a standalone task, unrelated to PR #25163. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25163 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @oliverguenther to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @oliverguenther, and request a review from @oliverguenther.
On every commit, set @oliverguenther as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@dfriquet dfriquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t reviewed the specs yet, but here is a first pass over the first 69 files.

Comment thread app/controllers/automations_controller.rb Outdated
Comment thread app/models/automations/triggers/manual.rb Outdated
Comment thread app/models/automation.rb Outdated
Comment thread app/services/automations/base_service.rb Outdated
Comment thread app/services/automations/base_service.rb Outdated
Comment thread app/services/automations/create_service.rb Outdated
Comment thread app/services/automations/update_service.rb Outdated
Comment thread db/migrate/20260907113318_convert_custom_actions_to_automations.rb Outdated
Comment thread app/models/automations/triggers/base.rb Outdated
Comment thread lib/api/v3/custom_actions/custom_action_representer.rb Outdated

@dfriquet dfriquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the second review, for the specs folder here. Nice opportunity for a specs-linting pass instead of just renaming 👍

One suggestion for the factory, and one change to drop entirely.

Comment thread spec/factories/automation_factory.rb Outdated
Comment thread spec/factories/automation_factory.rb Outdated
Comment thread spec/helpers/no_results_helper_spec.rb
@oliverguenther
oliverguenther force-pushed the feat/automations-namespace branch from a8cbe56 to 7d48d79 Compare September 25, 2026 09:14
@oliverguenther

Copy link
Copy Markdown
Member Author

@dfriquet Finally managed to address your review feedback, thanks 👍

@dfriquet dfriquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes reviewed 👍

One blocker before the merge: CI is failing on a automation specs — seems legit, not flaky.

One comment wannabe blocker: acts_as_list removal is not complete for triggers, cf my latest comment.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants