[AUTOWORK-205] Rename "CustomAction" to "Automations" namespace - #25163
oliverguenther wants to merge 1 commit into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ea25fe2 to
ce4d0ab
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
f7dc5ba to
30636c6
Compare
30636c6 to
32c9c11
Compare
a1f48af to
915aca3
Compare
|
I guess all files need the license header? |
915aca3 to
404a67e
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
404a67e to
a8cbe56
Compare
|
@klaustopher I went through all changed files and made sure the header is there |
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
dfriquet
left a comment
There was a problem hiding this comment.
I haven’t reviewed the specs yet, but here is a first pass over the first 69 files.
dfriquet
left a comment
There was a problem hiding this comment.
Here is the second review, for the specs folder here. Nice opportunity for a specs-linting pass instead of just renaming 👍
One suggestion for the factory, and one change to drop entirely.
a8cbe56 to
7d48d79
Compare
|
@dfriquet Finally managed to address your review feedback, thanks 👍 |
dfriquet
left a comment
There was a problem hiding this comment.
Latest changes reviewed 👍
One blocker before the merge: CI is failing on a automation specs — seems legit, not flaky.
One comment wannabe blocker: acts_as_list removal is not complete for triggers, cf my latest comment.
Converts all CustomAction references to automations, including tables and serialization. No functionality added, as automations will be created with a fixed trigger for "Manual button press"
https://community.openproject.org/work_packages/AUTOWORK-205