Drop FullCalendar's nonexistent dayGridClassNames option - #25362
Conversation
FullCalendar has no `dayGridClassNames` hook, so it warned on every calendar render; `dayCellClassNames` already marks non-working days.
dayGridClassNames option
|
Warning This pull request does not link an OpenProject work package. Please add a link to the work package in the description, or reference it in the |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Removes FullCalendar’s unsupported dayGridClassNames option and related workaround typings, eliminating warnings while preserving non-working-day styling.
Changes:
- Removes the invalid option and obsolete interfaces/imports.
- Uses standard
CalendarOptionstyping. - Retains supported class-name hooks.
File summaries
| File | Description |
|---|---|
frontend/src/app/features/calendar/te-calendar/te-calendar.component.ts |
Removes the unsupported option and workaround type. |
frontend/src/app/features/calendar/op-work-packages-calendar.service.ts |
Removes the same option and custom interface. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
Ticket
No work package. Frontend test-output hygiene, following up on #24622.
What are you trying to accomplish?
Removes the
Unknown option 'dayGridClassNames'warning that FullCalendar logs every time the time-entry calendar or the work package calendar renders. It shows up six times in thete-calendarspecs and also in the browser console in production.There is no behavior change. Non-working days are still marked through
dayHeaderClassNames,dayCellClassNames,slotLaneClassNamesandslotLabelClassNames.What approach did you choose and why?
FullCalendar 6 has no
dayGridClassNameshook. The class-name hook for day-grid cells isdayCellClassNames, which both calendars already set to the same callback. TheCalendarOptionsWithDayGridinterfaces only existed to let the unknown key typecheck, so they go too, and both option objects are typed as plainCalendarOptions.AI involvement
Directed – I specified the requirements and AI implemented most of it; I validated via testing rather than a full line-by-line review.
Merge checklist
fc-non-working-dayis already asserted by the calendar, team planner and My page feature specs