Implementation/COMMS-1047: Label creation API with case-insensitive dedupe - #25553
Open
akabiru wants to merge 4 commits into
Conversation
akabiru
added this pull request to stack #25555
September 23, 2026 20:57
This was referenced Sep 23, 2026
akabiru
force-pushed
the
implementation/comms-1047-label-creation-api
branch
from
September 24, 2026 06:13
4cfaa00 to
a249145
Compare
akabiru
force-pushed
the
implementation/comms-1047-label-creation-api
branch
from
September 24, 2026 07:03
a249145 to
08512b9
Compare
akabiru
force-pushed
the
implementation/comms-1047-label-creation-api
branch
from
September 24, 2026 13:39
08512b9 to
4feef22
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
akabiru
force-pushed
the
implementation/comms-1047-label-creation-api
branch
from
September 24, 2026 14:28
4feef22 to
d5ff4e4
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
akabiru
marked this pull request as ready for review
September 28, 2026 07:41
Creating a label from the work package dropdown must hand back the existing label when one with the same name in another casing exists, including when it appears concurrently between lookup and insert.
A duplicate inserted between the uniqueness validation and the INSERT raised through the admin form as a 500. The create service now turns the unique index violation into the same "taken" error, so every caller, including the find-or-create path, handles the race the same way.
Labels can now be created through the API.
akabiru
force-pushed
the
implementation/comms-1047-label-creation-api
branch
from
September 29, 2026 10:01
d5ff4e4 to
3e47058
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/COMMS-1047
Adds
POST /api/v3/labelsfor creating labels straight from the work package dropdown. Names are matched case-insensitively: an existing label with the same name in another casing is returned instead of creating a duplicate, including when it appears concurrently between validation and insert. The create service reports that race as the usual "already taken" error, so the admin form no longer fails on it.AI involvement
Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.