Skip to content

[OP-20221] Missing visual indicators that attachment size field is not editable - #25596

Open
HDinger wants to merge 2 commits into
devfrom
bug/op-20221-missing-visual-indicators-that-attachment-size-field-is-not-editable
Open

HDinger wants to merge 2 commits into
devfrom
bug/op-20221-missing-visual-indicators-that-attachment-size-field-is-not-editable

Conversation

@HDinger

@HDinger HDinger commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/OP-20221

What are you trying to accomplish?

Migrate the attachements setting form to primer

Screenshots

Default
Bildschirmfoto 2026-09-25 um 08 24 00

With OPENPROJECT_ATTACHMENT__MAX__SIZE being set
Bildschirmfoto 2026-09-25 um 08 24 33

AI involvement

None/Assisted – No AI assistance used OR only autocomplete/pasted snippets. I effectively wrote and understand all the code.

@HDinger HDinger added this to the 18.0.x milestone Sep 25, 2026
@github-actions github-actions Bot added the ai: None/Assisted 👤 No AI assistance used OR only snippets. A human effectively wrote and understands all the code. label Sep 25, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/team_planner/spec/features/team_planner_overview_spec.rb[1:4:4:1]
  • rspec ./spec/features/notifications/navigation_spec.rb[1:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25596, linked for reference only):

- `rspec ./modules/team_planner/spec/features/team_planner_overview_spec.rb[1:4:4:1]`
- `rspec ./spec/features/notifications/navigation_spec.rb[1:1:1]`

Treat this as a standalone task, unrelated to PR #25596. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25596 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@bsatarnejad bsatarnejad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is not read only, and there is no caption:

Screen.Recording.2026-09-29.at.16.54.14.mov

@HDinger

HDinger commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

The field is not read only, and there is no caption:
Screen.Recording.2026-09-29.at.16.54.14.mov

@bsatarnejad the field is not by default in read-only mode but only when OPENPROJECT_ATTACHMENT__MAX__SIZE is set. I assume you did not set it in your setup which is why it can still be edited (which is then correct).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility ai: None/Assisted 👤 No AI assistance used OR only snippets. A human effectively wrote and understands all the code. needs review

Development

Successfully merging this pull request may close these issues.

2 participants