[#676] Profile 탭을 ProfileTab 모듈로 분리한다#694
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 기존 Presentation 모듈에 있던 프로필 관련 기능들을 신규 ProfileTab 모듈로 분리하고 관련 테스트 및 설정을 추가하는 작업을 수행합니다. 이 과정에서 MainView의 일부 코드가 ProfileRegularDetailView로 추출되었습니다. 피드백으로는 ProfileRegularDetailView와 ProfileView 간에 중복되는 목적지 뷰 생성 로직을 공통 뷰로 분리하여 코드 재사용성과 유지보수성을 개선할 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
Profile 화면과 설정 하위 흐름을
Presentationroot target에서 분리해 탭 단위 모듈 구조로 정리하기 위함📝 작업 내용
📌 요약
ProfileTab,ProfileTabTeststarget 추가ProfileTab으로 이동ProfileTabTests로 이동MainView의 Profile 하위 내비게이션 조립 책임 축소waitUntilhelper 복구🔍 상세
Application/Presentation/Project.swift에ProfileTab,ProfileTabTeststarget 구성 추가ProfileView,ProfileFeature,SettingsView,AccountFeature,PushNotificationSettingsFeature,ThemeView등을Application/Presentation/ProfileTab/Sources하위로 이동ProfileRegularDetailView를ProfileTab내부 파일로 분리MainView는ProfileRegularDetailView진입만 처리하도록 단순화Application/Presentation/ProfileTab/Tests하위로 이동ObserveNetworkConnectivityUseCaseSpy,waitUntilhelper 복구📸 영상 / 이미지 (Optional)