refactor(buf): add go.mod to inventory api to resolve import into pro… - #481
Merged
Conversation
…jects Signed-off-by: Mark Sanders <marksanders194@gmail.com>
artek-koltun
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of the newer versions of golang >1.18 imported modules should have a go.mod file to define the language setting.
When using the generated protobuf files, the bridge code examples were failing with the newly generated files due to predeclared types which required newer versions of go. If a module doesn't have a go.mod definition with the language setting specified, it will default to 1.16. Many of the new declarations are not supported in 1.16 and the compile will fail.
Adding a go.mod file to the specific modules is required. This will be subsequently added to the other module areas in the v1/gen/go folder of the api.