Skip to content

fix: correct markdown table formatting - #486

Merged
sandersms merged 1 commit into
opiproject:mainfrom
bn222:fix/markdown-table-formatting
Jan 26, 2026
Merged

fix: correct markdown table formatting#486
sandersms merged 1 commit into
opiproject:mainfrom
bn222:fix/markdown-table-formatting

Conversation

@bn222

@bn222 bn222 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Make the linter pass

@bn222
bn222 requested a review from a team as a code owner December 18, 2025 12:43
@bn222
bn222 force-pushed the fix/markdown-table-formatting branch from 4dcf587 to 1eea4ad Compare December 18, 2025 13:06
Make the linter pass

Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
@bn222
bn222 force-pushed the fix/markdown-table-formatting branch from 1eea4ad to 3bc86b4 Compare December 18, 2025 13:12
@bn222

bn222 commented Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

@sandersms can you review this one? It's a very small change that fixes head.

@wizhaoredhat

Copy link
Copy Markdown

LGTM @sandersms / @pdp2shirts could you help merge it?
We have a lot of code to contribute (1000s of lines of go code from downstream). And we need a way to move fast. WDYT?

@sandersms sandersms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine - perhaps in the future we can re-enable the checks and resolve the issues in the markdown files.

@sandersms
sandersms merged commit 0b58e48 into opiproject:main Jan 26, 2026
5 checks passed
@bn222

bn222 commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

That alternative (re-enable + resolve) leads to a very hard to maintain md imo, and for that reason I've chosen the path to disable the check. Leaving this comment here for the future so that we consider it as input to create an issue to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants