fix(DEN-4080): enforce explicit numeric wire acceptance - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Forward explicit int64-strategy to the immutable shared validator; lossless string encoding remains the default.\n- Pin validator 43541bbeea698b518aa0b6b9dc1a0f0aabfb1375.\n- Add a numeric uint64 fixture bounded to JavaScript-safe integers, with explicit positive/negative corpus cases.\n- Require both correct-encoding success and wrong-encoding semantic divergence, in addition to the existing required-field drift test.\n- Ensure negative CI results reflect actual contract disagreements, not missing files or broken tooling.\n- Preserve authored fixture bytes and retain hidden evidence artifacts; use unique ignored repository-local scratch directories without destructive cleanup.\n\n## Validation\n\nSix guard unit tests passed locally. Real numeric compiler-backed parity passed: 23 probes, zero divergences. The wrong string encoding returned STOPPED_FOR_EVALUATION with actual divergences. Hosted composite-action acceptance is required before merge.\n\nNo live endpoint claim: this is compiler-backed contract acceptance. Existing Python guard is intentionally retained; Rust migration parity is tracked under DEN-4080.\n\nRefs #3; production consumer ores-chat/ores-chat-interfaces#13; Linear DEN-4080.