test(DEN-4080): normalize authored fixtures for TJSV corpus - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the production repository's independently authored fixture bytes while deriving a declaration-indexed corpus for the pinned
ORESoftware/typespec-json-schema-validatordifferential gate.TJSV intentionally treats the first corpus directory as the declaration (
instances/<Declaration>/...). ORES Chat production fixtures are currently arranged as<slice>/<Declaration>.json, so passing that tree directly makesadmin,conversations, etc. look like declaration names. This PR fixes the acceptance action rather than weakening or disabling TJSV's corpus checks.Behavior
$defsrather than hard-coding ORES Chat slices;<Declaration>/valid|invalid/*.jsonand<Declaration>/*.json);<slice>/<Declaration>.jsonto an isolated evidence-only<Declaration>/<slice>--<Declaration>.jsoncopy;ticket-created.json -> SupportEvent;24e3bb322b8d7c9cd2e0c7dd185d659ad3fd7328while the immutability receipt continues to bind the original authored inputs.Tests
support/Widget.jsonlayout from the existing convergent fixture and executes the complete composite action against it;No authored TypeSpec, JSON Schema, or fixture source becomes generated authority. Normalized corpus files are downstream evidence only.
Linear: DEN-4080; related DEN-3828 and DEN-3959.