table: skip rejected paths when building Drop withdrawals - #3536
Open
locker95 wants to merge 2 commits into
Open
table: skip rejected paths when building Drop withdrawals#3536locker95 wants to merge 2 commits into
locker95 wants to merge 2 commits into
Conversation
Rejected adj-RIB-In paths were never installed in the local RIB, so emitting withdrawals for them produces "No matching path for withdraw" noise on peer flaps. Clear them from adj state still, but only return withdrawals for paths that had been accepted. Fixes osrg#3455 Signed-off-by: Dean Chen <862469039@qq.com>
Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a peer flaps,
AdjRib.Drop()was cloning every adj-RIB-In path into a withdrawal list, including ones markedIsRejected(e.g. AS-loop rejects that never made it into the local RIB). Downstream withdraw processing then logs "No matching path for withdraw" for each of those.Skip rejected paths when building the withdrawal list. The adj table is still cleared for the families being dropped.
Fixes #3455