server: withdraw stale paths on RR cluster loops - #3586
Open
rastislavs wants to merge 1 commit into
Open
Conversation
When a newly selected path contains the local cluster ID, filterpath suppresses the reflected advertisement. If the previous best path was already advertised to that RR client, returning no update leaves the old route stale on the peer. To fix this, send an explicit withdrawal for the previously advertised path before rejecting the looped path.
rastislavs
marked this pull request as ready for review
September 2, 2026 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with stale paths when two route reflectors originate the same prefix and reflect routes to one another.
After they then both withdraw the local path, they can end up in a state with stale reflected routes on both RRs, even when none of them is advertising it anymore. See the attached reproducer: rr-self-reflect-repro.sh