Distinguish different types of table events in watch gRPC API - #3587
Open
SampleText2k77 wants to merge 2 commits into
Open
Distinguish different types of table events in watch gRPC API#3587SampleText2k77 wants to merge 2 commits into
SampleText2k77 wants to merge 2 commits into
Conversation
Rationale for this is mainly to distinguish initial paths dump from regular updates. Initial dump may come in as a series of WatchEventResponses when WatchEventRequest has non-zero BatchSize in table filter configuration. This produces a short period of inconsistency which may be critical for some clients: you have received a batch of paths during initial dump and not sure will there be more of them of there will come a regular update. The problem is somewhat illustrated in a test case. In theory this may also be the case for regular updates, but I haven't observed them coming and having multiple paths inside. This is why I left potentially batched updates having single UPDATE event type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this is mainly to distinguish initial paths dump from regular updates. Initial dump may come in as a series of WatchEventResponses when WatchEventRequest has non-zero BatchSize in table filter configuration. This produces a short period of inconsistency which may be critical for some clients: you have received a batch of paths during initial dump and not sure will there be more of them of there will come a regular update. The problem is somewhat illustrated in a test case.
In theory this may also be the case for regular updates, but I haven't observed them coming and having multiple paths inside. This is why I left potentially batched updates having single UPDATE event type.