server: apply AS path option updates without resetting sessions - #3588
Open
sillage-hjj wants to merge 1 commit into
Open
server: apply AS path option updates without resetting sessions#3588sillage-hjj wants to merge 1 commit into
sillage-hjj wants to merge 1 commit into
Conversation
Updating `AllowOwnAs`, `ReplacePeerAs`, or `AllowAsPathLoopLocal` currently makes `NeedsResendOpenMessage` request a session restart. These options can be applied by reprocessing routes, so updating them unnecessarily interrupts established sessions. Remove AS path options from the OPEN-message restart check. Report `NeedsSoftResetIn` for `AllowOwnAs` changes, reevaluate cached rejection state during inbound soft reset, and withdraw paths that are no longer accepted. Refresh outbound advertisements when `ReplacePeerAs` or `AllowAsPathLoopLocal` changes. Preserve peer-group inheritance and explicit member overrides, and update cached rejection state without growing path-parent history. Closes osrg#3582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
AllowOwnAs,ReplacePeerAs, orAllowAsPathLoopLocalcurrently makesNeedsResendOpenMessagerequest a session restart. These options can be applied by reprocessing routes, so updating them unnecessarily interrupts established sessions.Remove AS path options from the OPEN-message restart check. Report
NeedsSoftResetInforAllowOwnAschanges, reevaluate cached rejection state during inbound soft reset, and withdraw paths that are no longer accepted. Refresh outbound advertisements whenReplacePeerAsorAllowAsPathLoopLocalchanges. Preserve peer-group inheritance and explicit member overrides, and update cached rejection state without growing path-parent history.Testing
Passed on Linux with Go 1.27.1 and
CGO_ENABLED=1:go test -v -race -count=1 -p=8 -timeout 240s ./...GOARCH=386 go test -v -count=1 -p=8 -timeout 240s ./...golangci-lint run(v2.13.2)The UNIX-socket tests used short
TMPDIRandGOTMPDIRpaths. Thirty CI scenarios completed successfully across local and native Linux runs; upstream skips were unchanged.Closes #3582