Skip to content

fix(pdfx): guard page and visiblePages after viewer detach/dispose - #3

Open
Deni-al wants to merge 1 commit into
ovenbits:messengerxfrom
Deni-al:fix/pdfx-dispose-lifecycle-guards
Open

Deni-al wants to merge 1 commit into
ovenbits:messengerxfrom
Deni-al:fix/pdfx-dispose-lifecycle-guards

Conversation

@Deni-al

@Deni-al Deni-al commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • Return safe defaults when PdfViewPinch is detached or PdfController PageController is unavailable
  • Call _detach() in dispose() for both controller types
  • Prevents null-check crashes during dispose races (MOBILE-4B2 / 704)

Test plan

  • Paired with MessengerX client dispose guards in pdf_reader_page_view_model.dart
  • Manual: open PDF, navigate away during load — error state, no crash

Made with Cursor

@Deni-al
Deni-al force-pushed the fix/pdfx-dispose-lifecycle-guards branch 3 times, most recently from e4c944e to b1acfd0 Compare September 10, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant