FIX(zone_notification_extended): add support for notify entities - #169
Open
thomasgeens wants to merge 1 commit into
Open
FIX(zone_notification_extended): add support for notify entities#169thomasgeens wants to merge 1 commit into
thomasgeens wants to merge 1 commit into
Conversation
Route notifications through the modern `notify.send_message` action with an entity target when the notify service resolves to a notify entity, falling back to the legacy flat `service:` call inside the choose default otherwise. Details that make the entity path work: - Render `notify_service` with a folded scalar (`>-`) and Jinja whitespace control so it produces a clean `notify.<name>` string; the previous literal block leaked newlines/indentation into the value. - Slugify the group input so display-cased names (e.g. "Iedereen") resolve to the real entity id. - Detect entities via `states.notify | map(attribute='entity_id')`; `x in states` is false for entities whose state is "unknown" — the resting state of an unused notify group. - Send only `title` + `message` on the entity path; notify entities reject the rich mobile_app payload (extra keys not allowed). The legacy fallback keeps the full payload. - Mark all notify steps `continue_on_error: true` so one unreachable local-push target (e.g. a display without an active websocket) doesn't abort the remaining automation steps.
thomasgeens
marked this pull request as ready for review
July 10, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route notifications through the modern
notify.send_messageaction with an entity target when the notify service resolves to a notify entity, falling back to the legacy flatservice:call inside the choose default otherwise.Details that make the entity path work:
notify_servicewith a folded scalar (>-) and Jinja whitespace control so it produces a cleannotify.<name>string; the previous literal block leaked newlines/indentation into the value.states.notify | map(attribute='entity_id');x in statesis false for entities whose state is "unknown" - the resting state of an unused notify group.title+messageon the entity path; notify entities reject the rich mobile_app payload (extra keys not allowed). The legacy fallback keeps the full payload.continue_on_error: trueso one unreachable local-push target (e.g. a display without an active websocket) doesn't abort the remaining automation steps.