xls: add configurable hyperlink hook (HandleHyperlink)#25
Open
ShivangNagta wants to merge 1 commit into
Open
Conversation
The HLINK handler hardcoded the anchor cell's value to , overwriting the display text read from the shared-string table with the HLINK record's own (often empty or garbled) display field, and offered no way for callers to change this. Add a HyperlinkFunc hook (HandleHyperlink) that lets callers decide how hyperlink cells are rendered. When nil (the default) the historical behavior is unchanged, so this is backward compatible. A ready-made PreserveDisplayText hook keeps the cell's display text as the value and exposes the target via Cell.URL()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When parsing
.xls, the HLINK handler overwrites the anchor cell's value withdisplayText + " <" + linkText + ">". This discards the cell's display text(already read from the shared-string table) in favor of the HLINK record's own
display field, which is frequently empty or garbled - and callers had no way to
change it.
Change
HyperlinkFuncand the package-levelHandleHyperlinkhookHandleHyperlinkis nil (default), behavior is unchanged (backwardcompatible).
PreserveDisplayText, a ready-made hook that keeps the cell's displaytext as the value and exposes the target via
Cell.URL().