TURN refresh hardening + ChannelBind/CreatePermission timer fix - #16

Merged

havardgraff merged 30 commits into

masterfrom

copilot/analyze-turn-allocation-failure

Apr 30, 2026

Commits on Apr 29, 2026

apply speculative TURN refresh fixes + diagnostic logging

Copilot
and
havardgraff
committed
b3ea9b8
address review: preserve stun_message_find_error predicate; comment fix

Copilot
and
havardgraff
committed
f01167b
add round-2 fixes: suppress fatal signal when siblings alive, per-cand identity, heartbeat

Copilot
and
havardgraff
committed
53c7298
address review: log "never" for unset last_event; clarify off-by-one comment

Copilot
and
havardgraff
committed
f46d0ac
logs
havardgraff
committed
16e1a6a
logs
havardgraff
committed
a3ade21
Speculative-fix #13: send TURN lifetime=0 release exactly once

Copilot
and
havardgraff
committed
228dd34
new client logs
havardgraff
committed
289d278
new pcap
havardgraff
committed
19cf7b2
chrome packet capture
havardgraff
committed
4756f60
turn: fix refresh timers attached to wrong main context, add diagnostic logging, lower channel-bind refresh to 240 s

Copilot
and
havardgraff
authored
b5bb7f2
cleanup: remove pcaps/captured logs, drop heartbeat machinery, keep RFC-aligned fixes with descriptive logs

Copilot
and
havardgraff
authored
7069788
tests: add regression tests for GMainContext bug and refresh-interval invariants

Copilot
and
havardgraff
authored
04b5aca
tests: wire new tests into meson.build (drop autotools wiring)

Copilot
and
havardgraff
authored
1ee0910
turn: cache realm/nonce on refresh; add test-only timeout knobs

Copilot
and
havardgraff
authored
84b2e48
conncheck/tests: fix ms overflow, deflake mainctx test, exercise TURN timeout env knobs

Copilot
and
havardgraff
authored
b12e38b
turn: fix Source-ID-not-found crash on socket_close (timers attached to priv->ctx)

Copilot
and
havardgraff
authored
dcc6af9
socket/turn: fix Source-ID-not-found crash; tcp-bsd parens; agent.c format args

Copilot
and
havardgraff
authored
1b829d7
socket/turn: log when priv_source_remove_with_context finds no source (diagnostic)

Copilot
and
havardgraff
authored
a099a24
conncheck: honor NICE_TURN_EXPIRE_TIMEOUT for ALLOCATE refresh scheduling

Copilot
and
havardgraff
authored
6415153
conncheck: tear down TURN allocation when stale-nonce retries reach MAX

Copilot
and
havardgraff
authored
3c82a14
conncheck: cap consecutive stale-nonce retries at 4

Copilot
and
havardgraff
authored
14f589d
fixup we want 5
havardgraff
committed
5313ce6

Commits on Apr 30, 2026

conncheck: cache 200 OK ALLOCATE response so first Refresh uses fresh NONCE

Copilot
and
havardgraff
authored
e242069
propagate Refresh-rotated NONCE to TURN socket credential cache

Copilot
and
havardgraff
authored
995c318
conncheck: re-arm periodic Refresh on stale-nonce exhaustion instead of tearing down

Copilot
and
havardgraff
authored
07f0549
conncheck: re-read NICE_TURN_EXPIRE_TIMEOUT each refresh; warn when relay cand is dropped

Copilot
and
havardgraff
authored
efc1453
remove accidentally committed config.log

Copilot
and
havardgraff
authored
d816113
Update agent/discovery.h

havardgraff
and
Copilot
authored
571c472
Update tests/test-turn-refresh-interval.c

havardgraff
and
Copilot
authored
4366992

Navigation Menu

Uh oh!

TURN refresh hardening + ChannelBind/CreatePermission timer fix - #16

TURN refresh hardening + ChannelBind/CreatePermission timer fix#16
havardgraff merged 30 commits into
masterfrom
copilot/analyze-turn-allocation-failure

Commits on Apr 29, 2026

apply speculative TURN refresh fixes + diagnostic logging

address review: preserve stun_message_find_error predicate; comment fix

add round-2 fixes: suppress fatal signal when siblings alive, per-cand identity, heartbeat

address review: log "never" for unset last_event; clarify off-by-one comment

logs

logs

Speculative-fix #13: send TURN lifetime=0 release exactly once

new client logs

new pcap

chrome packet capture

turn: fix refresh timers attached to wrong main context, add diagnostic logging, lower channel-bind refresh to 240 s

cleanup: remove pcaps/captured logs, drop heartbeat machinery, keep RFC-aligned fixes with descriptive logs

tests: add regression tests for GMainContext bug and refresh-interval invariants

tests: wire new tests into meson.build (drop autotools wiring)

turn: cache realm/nonce on refresh; add test-only timeout knobs

conncheck/tests: fix ms overflow, deflake mainctx test, exercise TURN timeout env knobs

turn: fix Source-ID-not-found crash on socket_close (timers attached to priv->ctx)

socket/turn: fix Source-ID-not-found crash; tcp-bsd parens; agent.c format args

socket/turn: log when priv_source_remove_with_context finds no source (diagnostic)

conncheck: honor NICE_TURN_EXPIRE_TIMEOUT for ALLOCATE refresh scheduling

conncheck: tear down TURN allocation when stale-nonce retries reach MAX

conncheck: cap consecutive stale-nonce retries at 4

fixup we want 5

Commits on Apr 30, 2026

conncheck: cache 200 OK ALLOCATE response so first Refresh uses fresh NONCE

propagate Refresh-rotated NONCE to TURN socket credential cache

conncheck: re-arm periodic Refresh on stale-nonce exhaustion instead of tearing down

conncheck: re-read NICE_TURN_EXPIRE_TIMEOUT each refresh; warn when relay cand is dropped

remove accidentally committed config.log

Update agent/discovery.h

Update tests/test-turn-refresh-interval.c