Conversation
phate
approved these changes
Aug 2, 2026
Comment on lines
+884
to
+886
| /* ================================================================== */ | ||
| /* HLS SinkOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ |
|
|
||
| /* ================================================================== */ | ||
| /* HLS TriggerOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ |
|
|
||
| /* ================================================================== */ | ||
| /* HLS BranchOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ |
Comment on lines
+952
to
+955
| /* ================================================================== */ | ||
| /* HLS MuxOperation (NDMux) FIRRTL conversion test */ | ||
| /* ================================================================== */ | ||
|
|
| /* HLS ForkOperation FIRRTL conversion tests */ | ||
| /* ================================================================== */ | ||
|
|
||
| TEST_F(FirrtlTestBase, ForkOperation) |
Comment on lines
+1001
to
+1004
| /* ================================================================== */ | ||
| /* HLS StateGateOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ | ||
|
|
| /* ================================================================== */ | ||
| /* HLS PredicateBufferOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ | ||
|
|
|
|
||
| /* ================================================================== */ | ||
| /* HLS AddressQueueOperation FIRRTL conversion test */ | ||
| /* ================================================================== */ |
Owner
There was a problem hiding this comment.
Ah, I get tired of it. Just go through and eliminate the /* */
phate
previously approved these changes
Aug 2, 2026
Comment on lines
+1189
to
+1190
| // LocalStoreOperation: inputs {Bit(64) index, ValueType value, MemoryState*} | ||
| // outputs {...MemoryState*, Bit(64) addr} |
Comment on lines
+1160
to
+1161
| // LocalLoadOperation: inputs {Bit(64) index, MemoryState*, ValueType load_result} | ||
| // outputs {ValueType data, ...MemoryState*, Bit(64) addr} |
Comment on lines
+1110
to
+1111
| // HLS StoreOperation: inputs {Pointer addr, ValueType value, ...MemoryState*, MemoryState* resp} | ||
| // outputs {MemoryState*, PointerType, ValueType data} |
Comment on lines
+1081
to
+1082
| // HLS LoadOperation: inputs {Pointer addr, MemoryState*, ValueType load_result} | ||
| // outputs {ValueType data, ...MemoryState*, Pointer addr} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.