Skip to content

MLIR: Handle linkage for LambdaNode in frontend #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjalander merged 4 commits into from
Sep 17, 2026
Merged

MLIR: Handle linkage for LambdaNode in frontend #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cce077
MLIR: Handle linkage for LambdaNode
sjalander Sep 12, 2026
c3d8fa4
Merge remote-tracking branch 'phate/master' into roundtrip-pr8
sjalander Sep 15, 2026
19489ff
Always require linkage
sjalander Sep 16, 2026
3ebfff4
Merge remote-tracking branch 'phate/master' into roundtrip-pr8
sjalander Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jlm/mlir/RvsdgRoundtripTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,8 @@ ROUNDTRIP_TEST(TestVariadicFunctionTest1, ::jlm::llvm::VariadicFunctionTest1)
ROUNDTRIP_TEST(TestVariadicFunctionTest2, ::jlm::llvm::VariadicFunctionTest2)
ROUNDTRIP_TEST(TestGamma, ::jlm::llvm::GammaTest)
ROUNDTRIP_TEST(TestImport, ::jlm::llvm::ImportTest)
ROUNDTRIP_TEST(TestEscapingLocalFunction, ::jlm::llvm::EscapingLocalFunctionTest)
ROUNDTRIP_TEST(TestLambdaCallArgumentMismatch, ::jlm::llvm::LambdaCallArgumentMismatch)

// NAllocaNodesTest is parameterized by the number of allocas, so it cannot use the
// default-constructing ROUNDTRIP_TEST macro.
Expand Down
13 changes: 7 additions & 6 deletions jlm/mlir/frontend/MlirToJlmConverter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,14 +1223,15 @@ MlirToJlmConverter::ConvertLambda(
}
auto functionType = rvsdg::FunctionType::Create(std::move(argumentTypes), std::move(resultTypes));

// FIXME
// The linkage should be part of the MLIR attributes so it can be extracted here
// Get the linkage attribute from the MLIR LambdaNode
auto linkageAttribute = mlirOperation.getAttr(::llvm::StringRef("linkage"));
JLM_ASSERT(linkageAttribute != nullptr);
auto linkageStr = ::mlir::cast<::mlir::StringAttr>(linkageAttribute);
auto linkage = llvm::linkageFromString(linkageStr.str());

Comment thread
phate marked this conversation as resolved.
auto rvsdgLambda = rvsdg::LambdaNode::Create(
rvsdgRegion,
llvm::LlvmLambdaOperation::Create(
functionType,
functionName.getValue().str(),
llvm::Linkage::externalLinkage));
llvm::LlvmLambdaOperation::Create(functionType, functionName.getValue().str(), linkage));

for (auto input : inputs)
{
Expand Down
25 changes: 24 additions & 1 deletion jlm/mlir/frontend/MlirToJlmConverterTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ TEST(MlirToJlmConverterTests, TestLambda)
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
attributes.push_back(symbolName);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);
attributes.push_back(linkage);
::llvm::ArrayRef<::mlir::NamedAttribute> attributesRef(attributes);

// Add inputs to the function
Expand Down Expand Up @@ -185,6 +189,10 @@ TEST(MlirToJlmConverterTests, TestDivOperation)
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
attributes.push_back(symbolName);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);
attributes.push_back(linkage);
::llvm::ArrayRef<::mlir::NamedAttribute> attributesRef(attributes);

// Add inputs to the function
Expand Down Expand Up @@ -377,6 +385,10 @@ TEST(MlirToJlmConverterTests, TestCompZeroExt)
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
attributes.push_back(symbolName);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);
attributes.push_back(linkage);
::llvm::ArrayRef<::mlir::NamedAttribute> attributesRef(attributes);

// Add inputs to the function
Expand Down Expand Up @@ -601,6 +613,10 @@ TEST(MlirToJlmConverterTests, TestMatchOp)
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
attributes.push_back(symbolName);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);
attributes.push_back(linkage);
::llvm::ArrayRef<::mlir::NamedAttribute> attributesRef(attributes);

// Add inputs to the function
Expand Down Expand Up @@ -773,6 +789,10 @@ TEST(MlirToJlmConverterTests, TestGammaOp)
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
attributes.push_back(symbolName);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);
attributes.push_back(linkage);
::llvm::ArrayRef<::mlir::NamedAttribute> attributesRef(attributes);

// Add inputs to the function
Expand Down Expand Up @@ -925,6 +945,9 @@ TEST(MlirToJlmConverterTests, TestThetaOp)
auto attributeName = Builder_->getStringAttr("sym_name");
auto attributeValue = Builder_->getStringAttr("test");
auto symbolName = Builder_->getNamedAttr(attributeName, attributeValue);
auto linkageName = Builder_->getStringAttr("linkage");
auto linkageValue = Builder_->getStringAttr("external_linkage");
auto linkage = Builder_->getNamedAttr(linkageName, linkageValue);

auto iotype = Builder_->getType<IOStateEdgeType>();
auto memtype = Builder_->getType<MemStateEdgeType>();
Expand All @@ -937,7 +960,7 @@ TEST(MlirToJlmConverterTests, TestThetaOp)
::mlir::TypeRange({ iotype, memtype }),
::mlir::TypeRange({ iotype, memtype })),
::llvm::SmallVector<mlir::Value>(),
::llvm::ArrayRef<::mlir::NamedAttribute>({ symbolName }));
::llvm::ArrayRef<::mlir::NamedAttribute>({ symbolName, linkage }));
omegaBlock->push_back(lambda);
auto & lambdaRegion = lambda.getRegion();
auto * lambdaBlock = new mlir::Block;
Expand Down
Loading