Skip to content

Revert "Add region predication checking to the OutputTracer (#1892)" #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haved merged 1 commit into from
Sep 16, 2026
Merged

Revert "Add region predication checking to the OutputTracer (#1892)" #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions jlm/llvm/ir/Trace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,9 @@ OutputTracer::OutputTracer()
{}

rvsdg::Output &
OutputTracer::traceStep(
rvsdg::Output & output,
BackEdgeState backEdgeState,
const rvsdg::Region * withinRegion)
OutputTracer::traceStep(rvsdg::Output & output, const rvsdg::Region * withinRegion)
{
auto & trace1 = rvsdg::OutputTracer::traceStep(output, backEdgeState, withinRegion);
auto & trace1 = rvsdg::OutputTracer::traceStep(output, withinRegion);

if (const auto [node, ioBarrierOp] =
rvsdg::TryGetSimpleNodeAndOptionalOp<IOBarrierOperation>(trace1);
Expand Down Expand Up @@ -69,7 +66,6 @@ traceOutput(rvsdg::Output & output, bool mayEnterSubregions, const rvsdg::Region
mayEnterSubregions
? rvsdg::OutputTracer::StructuralNodePolicy::traceIntoSubregions
: rvsdg::OutputTracer::StructuralNodePolicy::traceThroughIfDetectedInvariant);
tracer.setRegionPredicateCheckingEnabled(mayEnterSubregions);
tracer.setEnterPhiNodes(mayEnterSubregions);
return tracer.trace(output, withinRegion);
}
Expand Down
3 changes: 1 addition & 2 deletions jlm/llvm/ir/Trace.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ class OutputTracer : public rvsdg::OutputTracer

protected:
[[nodiscard]] rvsdg::Output &
traceStep(rvsdg::Output & output, BackEdgeState backEdgeState, const rvsdg::Region * withinRegion)
override;
traceStep(rvsdg::Output & output, const rvsdg::Region * withinRegion) override;

private:
bool traceThroughLoadedStates_ = false;
Expand Down
5 changes: 5 additions & 0 deletions jlm/llvm/opt/alias-analyses/AliasAnalysisPrecisionEvaluator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@

#include <unordered_map>

namespace jlm::util
{
class GraphWriter;
}

namespace jlm::llvm::aa
{

Expand Down
Loading
Loading