Skip to content

Add region predication to output tracer - #1898

Open
haved wants to merge 3 commits into
masterfrom
output-tracer-region-predication
Open

haved wants to merge 3 commits into
masterfrom
output-tracer-region-predication

Conversation

@haved

@haved haved commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Also changes the return type of the traceStep functions to let the function declare that the returned output is done, and should not be traced any more.

This PR was previously merged and then reverted because the previous version would re-try tracing for as long as the output changed. This could cause exponential re-trying in the case of deeply nested gammas. When a gamma was found where only one subregion could provide the value, it would fully trace the origin within the subregion, and then fully trace it once again. With multiple tracing loops inside one another this explodes.

@haved
haved requested a review from phate September 17, 2026 14:23
@haved
haved enabled auto-merge (squash) September 17, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant