feat: add saturating quantize_round - #32
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15eed8ddbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo xtask ci passed. All runnable checks passed; no checks skipped.
The final thumbv6m linked exercise sizes compared with pre-change main are:
Static RAM remains zero and no panic or wide-division symbols were linked.
Scope audit
No golden file, budget, existing quantize/expand behavior, type-state rule, dependency, version, tag, release, registry setting, or repository setting changed. ph-color-bake is untouched.
The brief did not conflict with AGENTS.md, docs/NUMERICS.md, CONTRIBUTING.md, or RELEASING.md. CONTRIBUTING.md additionally requires every new feature surface to be reachable from ph-color-exercise; that coupled edit is included so the resource evidence covers this API.