Make review policy honest for solo maintenance - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GitHub does not permit pull request authors to approve their own pull requests. Requiring one approval while the repository has only one collaborator creates an unsatisfiable gate and encourages bypasses. The live
mainprotection now honestly requires zero approvals while retaining PR-only integration, strictci, resolved review conversations, administrator enforcement, and force-push/deletion protection.Validation
cargo fmt --all -- --checkgit diff --checkmainprotection: approval count 0, last-push approval off, strictciand conversation resolution retainedrelease/**ruleset already uses the same zero-approval enforcement model