feat(api): add framework-neutral PanelComparison for ordered panel IDs, failure precedence, capture states, and combined structural/state counts without changing adapter output or diagnostic values. - #37
Conversation
…IDs, failure precedence, capture states, and combined structural/state counts without changing adapter output or diagnostic values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 99.95% 99.95%
- Complexity 2063 2075 +12
=========================================
Files 157 158 +1
Lines 8278 8328 +50
=========================================
+ Hits 8274 8324 +50
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (7)
🧰 Additional context used🪛 LanguageToolCHANGELOG.md[style] ~42-~42: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE) 🪛 PHPMD (2.15.0)tests/Provider/PanelComparisonProvider.php[warning] 20-207: The method comparisons() has 188 lines of code. Current threshold is set to 100. Avoid really long methods. (undefined) (ExcessiveMethodLength) [error] 22-22: Avoid using static access to class '\PHPForge\Debug\Storage\RequestSummary' in method 'comparisons'. (undefined) (StaticAccess) tests/Comparison/PanelComparisonTest.php[error] 34-34: Avoid using static access to class '\PHPForge\Debug\Comparison\PanelComparison' in method 'testBetweenPreservesPanelContracts'. (undefined) (StaticAccess) src/Comparison/PanelComparison.php[warning] 24-24: Avoid variables with short names like $id. Configured minimum length is 3. (undefined) (ShortVariable) [warning] 57-57: Avoid unused local variables such as '$_label'. (undefined) (UnusedLocalVariable) [error] 78-81: Avoid using static access to class 'PHPForge\Debug\Comparison\PayloadDifference' in method 'between'. (undefined) (StaticAccess) [warning] 112-112: Avoid variables with short names like $id. Configured minimum length is 3. (undefined) (ShortVariable) [warning] 121-121: Avoid variables with short names like $id. Configured minimum length is 3. (undefined) (ShortVariable) 🔇 Additional comments (5)
📝 SummarySummary by CodeRabbit
WalkthroughAdds the framework-neutral ChangesPanel comparison API
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This adds a panel-comparison API without changing existing adapter output or serialized diagnostics. The documented comparison behavior is covered by tests, with no remaining merge-readiness risk identified. Sequence Diagram(s)sequenceDiagram
participant Baseline as DebugSnapshot baseline
participant Target as DebugSnapshot target
participant Comparison as PanelComparison::between
participant Results as PanelComparison results
Comparison->>Baseline: read payload and failure IDs
Comparison->>Target: read payload and failure IDs
Comparison->>Comparison: order IDs and compute states and counts
Comparison->>Results: create ordered immutable results
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request