Handle role conflict 487 error responses - #892
Open
bgardner8008 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #892 +/- ##
==========================================
- Coverage 88.57% 88.07% -0.51%
==========================================
Files 44 44
Lines 5540 5625 +85
==========================================
+ Hits 4907 4954 +47
- Misses 439 463 +24
- Partials 194 208 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implements the requester side of RFC 8445 role conflict resolution. The existing code handles role conflicts detected in inbound Binding requests (section 7.3.1.1), but did not handle 487 error responses received when we are the requester (section 7.2.5.1). This adds handling for that case: - Verify message integrity of the 487 response - Switch ICE role (controlling <-> controlled) - Regenerate the tiebreaker value, as required by the RFC - Re-enqueue the candidate pair in the triggered-check queue
bgardner8008
force-pushed
the
pr/handle-role-conflict-487
branch
from
August 3, 2026 20:01
4cb7c19 to
fd5d8a3
Compare
Author
|
Rebased onto current main and squashed into a single commit to resolve the merge conflicts (agent.go's |
Member
|
Hello, sorry I missed this will review it tonight, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the missing half of RFC 8445 §7.2.5.1: handle 487 Role Conflict error responses.
The existing code (commit 2c04474) handles role conflicts detected in inbound Binding requests (§7.3.1.1), but did not handle 487 error responses received when we are the requester.
This change adds handling for the requester side: