update graph-maker version - #137
Merged
Merged
Conversation
Comment on lines
+2
to
+3
| '@platforma-open/milaboratories.graph-maker': patch | ||
| '@platforma-open/milaboratories.graph-maker.ui': patch |
There was a problem hiding this comment.
The changeset omits the published @platforma-open/milaboratories.graph-maker.model package even though that package directly consumes the upgraded Graph Maker dependency. Changesets will not infer its release from an external catalog update. As a result, the block can bundle the newly built model while the standalone model package remains at its old version and dependency, leaving the published artifacts inconsistent.
Suggested change
| '@platforma-open/milaboratories.graph-maker': patch | |
| '@platforma-open/milaboratories.graph-maker.ui': patch | |
| '@platforma-open/milaboratories.graph-maker': patch | |
| '@platforma-open/milaboratories.graph-maker.model': patch | |
| '@platforma-open/milaboratories.graph-maker.ui': patch |
Knowledge Base Used: Build and release automation
Prompt To Fix With AI
This is a comment left during a code review.
Path: .changeset/calm-gifts-tap.md
Line: 2-3
Comment:
**Model Release Is Missing**
The changeset omits the published `@platforma-open/milaboratories.graph-maker.model` package even though that package directly consumes the upgraded Graph Maker dependency. Changesets will not infer its release from an external catalog update. As a result, the block can bundle the newly built model while the standalone model package remains at its old version and dependency, leaving the published artifacts inconsistent.
```suggestion
'@platforma-open/milaboratories.graph-maker': patch
'@platforma-open/milaboratories.graph-maker.model': patch
'@platforma-open/milaboratories.graph-maker.ui': patch
```
**Knowledge Base Used:** [Build and release automation](https://app.greptile.com/milaboratories/-/custom-context/knowledge-base/platforma-open/graph-maker/-/docs/build-and-release-automation.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR upgrades the shared Graph Maker library from 1.6.1 to 1.8.0 and the Platforma block tooling from 2.12.9 to 2.15.0, regenerates their transitive dependency resolutions, and adds patch-release metadata for the block and UI packages.
Important touched terms
@milaboratories/graph-makerpackage providing graph state types and the Vue graph editor component. It changes from 1.6.1 to 1.8.0.catalog:specifiers. Its Graph Maker and block-tools pins are updated.Confidence Score: 4/5
The PR should not merge until the model package is included in the release metadata so its published artifact remains consistent with the model bundled into the block.
The dependency updates and lockfile are coherent, but the changeset leaves a directly affected publishable package unreleased, causing standalone model consumers to remain on the previous artifact while the block ships the rebuilt model.
Files Needing Attention: .changeset/calm-gifts-tap.md
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "update graph-maker version" | Re-trigger Greptile
Context used: