feat(theme): add dynamic XP appearance - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompositorSurfaceviewportsvia-*gradient stopsValidation
bun run check(50 unit tests, 4 System UI sim journeys, 3 wrap-op tests)bun run build:web && bun run test:web(real headless Chrome; Hero AppInstance started and composited)bun run buildbun run macos -- --quit-after 5(native release host launched; 5 ticks, 4 frames)bun run capturewith visual inspection ofdocs/xp-theme.pnggit diff --checkGeometry contract
The same
ChromeMetricsdrive rendering and hit testing. Theme switches reframe normal, minimum, and maximized/restore geometry around a stable client rectangle; tests pin the XP 21px caption controls, 2px gaps, 30px taskbar, and client-size round trip.Assets
The XP caption glyphs are original code-generated SVGs. No Sheru files or third-party Windows assets are copied.