chore(RemotingNG, CodeGeneration): C++ attributes and deprecated credentials setters #5447 - #5505
Merged
Merged
Conversation
…ejects it in the class head #5447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5447 (follows #5483).
RemotingNG, CodeGeneration and RemoteGen were imported after #5156 and #5463 and carry none of the 2.0 attributes. This brings them in line with the core:
[[nodiscard]]on getters, queries, factories and scoped guards,[[noreturn]]on always-throw functions andrethrow()overrides,POCO_DEPRECATEDon the credentials setters.[[nodiscard]], 3[[noreturn]]; the two ignoredFrameQueue::handleFrameresults are asserted.Transport::setUsername/setPassword/getUsername/getPassword(SOAP, JSONRPC, REST) deprecated in favor ofsetCredentials()/getCredentials(); library, testsuites, samples and user guides migrated.Tests: macOS clang and Linux GCC full builds with tests and samples; 676 CppUnit cases pass on both; clang-tidy and cppcheck report nothing new on the changed lines.
Follow-ups (separate issues): RemoteGen neither propagates attributes from the input header nor emits them on generated overrides;
ClientHelper.hdefines the server helper macro.