Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft fix for #5506.
I reproduced the vulnerability locally using a raw TCP socket script, which confirmed receiveFrame was bypassing RFC validations. I've added strict validations in WebSocketImpl.cpp to catch:
Reserved opcodes
Non-zero RSV bits
Control frame fragmentation & payload limits
Masking direction (_mustMaskPayload)
The core logic successfully catches and rejects the malformed frames locally.
Also I had an Architectural question, I know that RFC 6455 requires failing the connection for non-zero RSV bits unless an extension is negotiated. Currently, I am rejecting all non-zero RSV bits. Does Poco natively track if a specific WebSocket extension was negotiated during the handshake so I can selectively allow RSV bits, or is a blanket rejection acceptable for our current scope?
Also, could a maintainer point me to the best file in Net/testsuite to add the unit tests for these specific framing errors? I'll get those added before marking this ready for review.