Foundation: Synchronize channel replacement and prevent FileChannel data races - #5509
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses thread-safety issues during dynamic channel replacement and logging in POCO Foundation:
Logger Channel Synchronization:
_channelMutexinPoco::Loggerguarding channel assignment (setChannel) and retrieval (getChannel).Channel::Ptrreference undergetChannel()before invokingpChannel->log(...), ensuring active message logging remains valid even if another thread resets or changes the channel concurrently.FormattingChannel Synchronization:
_pFormatterand_pChannelaccessors and mutators inPoco::FormattingChannel.FileChannel Mutex Scope:
unsafeOpen()to ensure file handle initialization and rotation checks occur under the existing_mutexlock inFileChannel::log(), avoiding race conditions between open and log operations across concurrent threads.Unit & Concurrency Tests:
testConcurrentChannelReplacementandtestConcurrentShutdowntoFoundation/testsuite/src/LoggerTest.cppverifying stability under multi-threaded channel mutation.Validation
ubuntu:noble).Foundation-testrunner LoggerTestexecuted and passed 100% (9/9 tests OK).