port to Rust to leverage deterministic simulating testing - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some consideration, I've decided to port pg2iceberg to Rust specifically to leverage deterministic simulating testing (DST). This is crucial to ensure that pg2iceberg data mirroring is correct. The architecture remains the same, but there are breaking changes due to interface differences (it's not 1.0.0 yet, so it's fine).
E2E tests are copied almost verbatim, with few additional changes:
uuidtype is queried in the wrong byte ordering (should be fixed in 26.4). Pre-Rust port, pg2iceberg did not useuuidtype, it usesstringinstead because I didn't know Iceberg has nativeuuidtype.pg2iceberg also depends on forked iceberg-rust due to missing features upstream (only 4 commits): https://github.com/polynya-dev/iceberg-rust/tree/polynya-patches