fix another deadlock while streaming cdc - #71
Merged
Merged
Conversation
hasyimibhar
force-pushed
the
fix/cdc-standby-ack-events-channel-full
branch
from
June 3, 2026 07:29
ab4b1b2 to
0188cfb
Compare
hasyimibhar
force-pushed
the
fix/cdc-standby-ack-events-channel-full
branch
from
June 3, 2026 07:30
0188cfb to
57b51c3
Compare
hasyimibhar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #70, it's a deadlock found while working on benchmark, it only happens under sustained write load.
Fixed by routing every event send through
send_servicing_cmds, whichselect!s the send permit (events_tx.reserve()) againstcmd_rx.recv(). AStandbyis now acked even when the events channel is full → main loop resumes → drains the channel → frees a slot → the send completes.Cmdhandling is factored intohandle_cmd, shared by the mainselect!arm and the send-wait path.