`gx` isn't working with Vim 9.1

[rbohl]

Using gx on a link in a markdown file doesn't work, with the error:

Error detected while processing function <SNR>37_OpenUrlUnderCursor[8]..<SNR>37_VersionAwareNetrwBrowseX:
E118: Too many arguments for function: netrw#BrowseX

Vim version 9.1:

VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Aug 10 2025 19:46:14)
Included patches: 1-1623
Compiled by Arch Linux
Huge version without GUI.

I believe it's a vim-markdown issue because after blacklisting the plugin, Vim's default gx works as expected.

[talex5]

The plugin passes two arguments to BrowseX:

vim-markdown/ftplugin/markdown.vim

Lines 746 to 752 in 8f6cb3a

	function! s:VersionAwareNetrwBrowseX(url)
	if has('patch-7.4.567')
	call netrw#BrowseX(a:url, 0)
	else
	call netrw#NetrwBrowseX(a:url, 0)
	endif
	endf

But vim/vim#17616 changed it to accept only one. See vim/vim#17794 - it looks like :Open should be used now instead.

[alerque]

Thanks for tracking down a fix @talex5. Can you PR that change please? I suppose we'll need another conditional checking for the VIM version that introduced that change, then fall back to the current two backup options.

[talex5]

Not likely to get around to that soon, so if someone else wants to try, go ahead!

[alerque]

Can anybody check and confirm that #674 works for them, either the old usage still working on older VIM and/or the new usage working on fresh VIM versions?

Note that this has not landed in Neovim yet so Neovim users should still get the old usage, but I haven't confirm that as working either.

[rbohl]

Hey, it works on my 9.1. Thank you!

[alerque]

I checked this works on Neovim (that doesn't have that patch yet in the current release, although it is merged to the master branch), so we'll call that good unless somebody else reports issues.

[alerque]

I just confirmed that this does not work in VIM 9.1.1841, so something is wrong. Perhaps this changed merged earlier than what I found...

[alerque]

I just read the wrong field when reviewing when the patch merged...

vim/vim@0bda783

Now corrected and tested to work in VIM prior to the change as well