feat(ad-hoc): nAPM cancellation reason message - #533
Merged
andrii-vysotskyi-cko merged 6 commits intoAug 10, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds cancellation reasons to native alternative payment failures and lifecycle cleanup for payment components.
Changes:
- Distinguishes customer, lifecycle, and programmatic cancellation.
- Includes the reason in nAP cancellation failures.
- Cancels nAP and card components on deallocation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
DefaultNativeAlternativePaymentViewModel.swift |
Supplies customer or lifecycle reasons. |
NativeAlternativePaymentInteractor.swift |
Adds reason-based cancellation API. |
NativeAlternativePaymentDefaultInteractor.swift |
Produces reason-specific failure messages. |
NativeAlternativePaymentCancelationReason.swift |
Defines cancellation reasons. |
PONativeAlternativePaymentComponent.swift |
Adds programmatic and lifecycle cancellation. |
POCardTokenizationComponent.swift |
Adds lifecycle cancellation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Sources/ProcessOutUI/Sources/Modules/NativeAlternativePayment/Interactor/NativeAlternativePaymentCancelationReason.swift:11
Cancelationis misspelled; the noun isCancellation, which is also the spelling used throughout this codebase. Rename this type (and its file/references) toNativeAlternativePaymentCancellationReason.
enum NativeAlternativePaymentCancelationReason {
vitalii-vanziak-cko
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-