Skip to content

test(recc): align seam tests with runner rollback - #650

Closed
castrojo wants to merge 2 commits into
mainfrom
fix/recc-runner-seam-tests
Closed

test(recc): align seam tests with runner rollback#650
castrojo wants to merge 2 commits into
mainfrom
fix/recc-runner-seam-tests

Conversation

@castrojo

Copy link
Copy Markdown
Collaborator

Summary

  • Classify the missing Dakota RECC seam as a deliberate rollback, not a regression.
  • Update the seam tests to cover the documented outer-remote-execution path: production lanes retain the shared helper mount but do not invoke nested RECC or probe the unavailable runner socket.

Evidence

  • 6e932b442 (feat(recc): wire the fail-closed runner seam) added the mandatory overlay invocation and buildbarn-config admission probe.
  • 1004110a0 (fix(bst): roll back unsatisfiable nested-RECC admission gate) explicitly removed both from Dakota, Cosmic, Bluefin Server, BST QA, and cache warmup because the pinned bb_runner cannot consume remoteApisSocketPath.
  • Live verification shows BuildBarn is running (frontend, scheduler, worker, and bb-remote-asset pods) and buildbarn-config exists, but the deployed runner config has no remoteApisSocketPath field.

Dakota still uses outer BuildStream remote execution and BuildBarn artifact/cache endpoints. It is currently missing only the nested RECC compiler-cache overlay by design. scripts/apply_recc_overlay.py is not dead code: it remains embedded in the shared ConfigMap and is invoked by the operator-only recc-baseline-pipeline; it is simply not invoked by production lanes until a capable runner is deployed.

Validation

  • just lint — passed
  • argo lint --offline argo/workflow-templates/ — passed
  • pytest -q tests/unit/test_recc_runner_seam.py — 13 passed
  • pytest -q tests/unit — 385 passed, 4 pre-existing unrelated failures (no new failures)

pi and others added 2 commits August 13, 2026 18:06
The nested RECC admission and overlay were deliberately rolled back in 1004110 because the deployed BuildBarn runner cannot consume remoteApisSocketPath. Keep coverage for the documented outer-remote-execution path while retaining the helper for the operator baseline and future runner rollout.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Production lanes must remain on outer BuildStream remote execution until the pinned BuildBarn runner consumes remoteApisSocketPath. Keep the shared helper available for the operator baseline without invoking it in production.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@castrojo

Copy link
Copy Markdown
Collaborator Author

Superseded by #654, which landed these exact test changes as part of unblocking main.

main had become un-mergeable: every open PR failed the required test-validation check on the same 7 pre-existing baseline failures, and each PR fixed only a subset — so none could go green on its own. #654 collected every test-side fix into a single change to break that deadlock.

Verified: every file in this PR is now byte-identical to main, so there is nothing left to merge. The analysis here was correct and is preserved in #654's history — closing only to avoid a no-op merge commit. Thanks!

@castrojo castrojo closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant