test(recc): align seam tests with runner rollback - #650
Closed
castrojo wants to merge 2 commits into
Closed
Conversation
The nested RECC admission and overlay were deliberately rolled back in 1004110 because the deployed BuildBarn runner cannot consume remoteApisSocketPath. Keep coverage for the documented outer-remote-execution path while retaining the helper for the operator baseline and future runner rollout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Production lanes must remain on outer BuildStream remote execution until the pinned BuildBarn runner consumes remoteApisSocketPath. Keep the shared helper available for the operator baseline without invoking it in production. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Superseded by #654, which landed these exact test changes as part of unblocking
Verified: every file in this PR is now byte-identical to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
6e932b442(feat(recc): wire the fail-closed runner seam) added the mandatory overlay invocation andbuildbarn-configadmission probe.1004110a0(fix(bst): roll back unsatisfiable nested-RECC admission gate) explicitly removed both from Dakota, Cosmic, Bluefin Server, BST QA, and cache warmup because the pinnedbb_runnercannot consumeremoteApisSocketPath.frontend,scheduler,worker, andbb-remote-assetpods) andbuildbarn-configexists, but the deployed runner config has noremoteApisSocketPathfield.Dakota still uses outer BuildStream remote execution and BuildBarn artifact/cache endpoints. It is currently missing only the nested RECC compiler-cache overlay by design.
scripts/apply_recc_overlay.pyis not dead code: it remains embedded in the shared ConfigMap and is invoked by the operator-onlyrecc-baseline-pipeline; it is simply not invoked by production lanes until a capable runner is deployed.Validation
just lint— passedargo lint --offline argo/workflow-templates/— passedpytest -q tests/unit/test_recc_runner_seam.py— 13 passedpytest -q tests/unit— 385 passed, 4 pre-existing unrelated failures (no new failures)