refactor: drop redundant reference check in Labels.isEmpty() - #2440
Open
david-mollitor-db wants to merge 1 commit into
Open
refactor: drop redundant reference check in Labels.isEmpty()#2440david-mollitor-db wants to merge 1 commit into
david-mollitor-db wants to merge 1 commit into
Conversation
The `this == EMPTY` clause is redundant: Labels.equals() already begins with `if (this == o) return true;`, so `this.equals(EMPTY)` covers the singleton case the reference check guards. Removing it is behavior-preserving and also removes the sole reason for the @SuppressWarnings("ReferenceEquality"). Signed-off-by: David Mollitor <david.mollitor@databricks.com>
david-mollitor-db
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
September 1, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplify
Labels.isEmpty()by dropping the redundantthis == EMPTYreference check.Why
Labels.equals()already begins withif (this == o) return true;, sothis.equals(EMPTY)already returnstruefor theEMPTYsingleton that thethis == EMPTYclause guards. Removing the clause is therefore behavior-preserving, and it was the sole reason for the@SuppressWarnings("ReferenceEquality")annotation, which is removed as well.This also aligns
isEmpty()with the rest ofLabels, which already usesthis.equals(EMPTY)(e.g. intoString()).This pull request and its description were written by Isaac.