Skip to content

perf: skip snapshot rebuild in mergeDuplicates when names are unique #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-mollitor-db wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: skip snapshot rebuild in mergeDuplicates when names are unique #2441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...ion-textformats/src/main/java/io/prometheus/metrics/expositionformats/TextFormatUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,24 @@ public static MetricSnapshots mergeDuplicates(MetricSnapshots metricSnapshots) {
return metricSnapshots;
}

// MetricSnapshots is sorted by prometheus name, so any duplicates are adjacent. Detect them in
// a single allocation-free pass; when there are none (the common case) return the input as-is
// rather than rebuilding it through a map, a list per group and a new MetricSnapshots.
boolean hasDuplicates = false;
for (int i = 1; i < metricSnapshots.size(); i++) {
if (metricSnapshots
.get(i)
.getMetadata()
.getPrometheusName()
.equals(metricSnapshots.get(i - 1).getMetadata().getPrometheusName())) {
hasDuplicates = true;
break;
}
}
if (!hasDuplicates) {
return metricSnapshots;
}

Map<String, List<MetricSnapshot>> grouped = new LinkedHashMap<>();

for (MetricSnapshot snapshot : metricSnapshots) {
Expand Down