Feature/mixing time#175
Draft
gpapadimitri wants to merge 1 commit into
Draft
Conversation
…g method with optional perceptual regression from Lindau et al. (2012). Includes tests/test_parameters_mixing_time.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
None #
Changes proposed in this pull request:
pyrato.parameters.mixing_time, estimating the mixing time from the echo density profile after criterion I of Abel & Huang (2006), with an optional Lindau et al. (2012) regression.rir.cshape.tests/test_parameters_mixing_time.py(15 cases): shape and type contract, the three error paths, the Lindau affine map and its clipping branch, window-length rounding, and the multichannel cut.Note: The implementation follows AKtools MATLAB implementation.
Transition times and lindau_regression were cross-checked against AKtool (
AKcutIRmixingTime+AKmixingTimeAbel+AKdataBasedMixingTime) on impulse responses, including theroom_impulse_response_with_noise.csvintests/test_data/. The two implementations agree, and those values are used as reference in the test.