Fix inconsistent strict_optional documentation#21661
Conversation
A5rocks
left a comment
There was a problem hiding this comment.
Sorry but this docs change is kind of nonsensical.
4e830ea to
fbf67f7
Compare
A5rocks
left a comment
There was a problem hiding this comment.
Looks good to me. @95-martin-orion what do you think?
I don't see where these links were added, but otherwise this fixes the issue I was seeing. Thanks! |
|
I asked them to remove the links since it didn't seem to add anything, since the sections are already describing strict-optional. |
|
Fair enough. My concern (which does not need to block this PR) was that the note " |
Summary
Fix the inconsistent description of
strict_optionalin the documentation.Changes
strict_optional = trueenables checking of optional types andNonevalues.strict_optional = falsedisables that checking.strict_optionaland--no-strict-optionalwarnings to the "Optional types and the None type" documentation for additional context.Fixes #21658