Add CornellBox denoising and upscaling and refactor rendering passes

[qian-o]

Summary

CornellBox now uses a path-tracing, denoising, upscaling, and tone-mapping pipeline with adjustable render resolution and selectable spatial or temporal upscaling. This replaces its rasterization mode and requires ray-tracing support.

• Add temporal reprojection and five à-trous filtering passes, using depth, normal, and motion-vector outputs from path tracing.
• Refactor CornellBox and FluidTank rendering passes around explicit dimensions, shared frame arguments, and consistent resource ownership.
• Refine FluidTank surface coverage, choose reflection shaders from device capabilities, and always enable antialiasing.
• Standardize InkCanvas disposal and update ImageSharp to 4.1.2.

[Copilot]

🟡 Changes recommended

Critical pass-initialization issues and moderate shader, resize, and caching issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR replaces CornellBox rasterization with a ray-traced denoising/upscaling pipeline and refactors FluidTank rendering and resource ownership.

Changes:

• Adds path tracing, denoising, spatial/temporal upscaling, and tone mapping.
• Refactors FluidTank passes, surface coverage, reflections, and antialiasing.
• Standardizes disposal and updates Vulkan handling and ImageSharp.

File summaries

File	Summary
sources/Zenith.NET.Vulkan/VKSwapChain.cs	Updates optional pointer handling.
sources/Experiments/InkCanvas/Drawing/Toolbar.cs	Standardizes disposal.
sources/Experiments/InkCanvas/Drawing/Stroke.cs	Standardizes disposal.
sources/Experiments/InkCanvas/Drawing/CanvasController.cs	Standardizes disposal.
sources/Experiments/InkCanvas/Drawing/Canvas.cs	Standardizes disposal.
sources/Experiments/FluidTank/Simulation.cs	Refactors simulation resources.
sources/Experiments/FluidTank/Renderer.cs	Coordinates rendering passes.
sources/Experiments/FluidTank/Passes/WaterPass.cs	Adds capability-based reflection shaders.
sources/Experiments/FluidTank/Passes/SurfacePass.cs	Adds surface outputs and coverage data.
sources/Experiments/FluidTank/Passes/ScenePass.cs	Refactors scene resources.
sources/Experiments/FluidTank/Passes/Pass.cs	Adds shared pass lifecycle.
sources/Experiments/FluidTank/Passes/OutputPass.cs	Enables tone mapping and antialiasing.
sources/Experiments/FluidTank/Passes/GlassPass.cs	Refactors glass rendering.
sources/Experiments/FluidTank/Models/SceneResources.cs	Refactors scene ownership.
sources/Experiments/FluidTank/Models/PassArgs.cs	Adds shared render arguments.
sources/Experiments/FluidTank/Models/ParticleData.cs	Makes particle data immutable.
sources/Experiments/FluidTank/Models/FrameData.cs	Removes obsolete frame data.
sources/Experiments/FluidTank/Models/FluidViewMode.cs	Makes enum values explicit.
sources/Experiments/FluidTank/Models/FluidTankGeometry.cs	Moves geometry into the models namespace.
sources/Experiments/FluidTank/Helpers/GraphicsHelper.cs	Removes obsolete helpers.
sources/Experiments/FluidTank/Handlers/ImGuiHandler.cs	Updates platform handling.
sources/Experiments/FluidTank/Assets/Shaders/Output.slang	Outputs luminance metadata.
sources/Experiments/FluidTank/Assets/Shaders/FluidComposite.slang	Adds coverage-aware compositing.
sources/Experiments/FluidTank/App.cs	Updates UI and rendering integration.
sources/Experiments/CornellBox/Renderers/Renderer.cs	Removes the old renderer base.
sources/Experiments/CornellBox/Renderers/RasterizationRenderer.cs	Removes rasterization rendering.
sources/Experiments/CornellBox/Renderer.cs	Adds the pipeline coordinator.
sources/Experiments/CornellBox/Properties/launchSettings.json	Adjusts formatting.
sources/Experiments/CornellBox/Program.cs	Updates entry-point formatting.
sources/Experiments/CornellBox/Passes/UpscalePass.cs	Adds spatial and temporal upscaling.
sources/Experiments/CornellBox/Passes/TonemapPass.cs	Adds compute tone mapping.
sources/Experiments/CornellBox/Passes/PathTracingPass.cs	Adds path-tracing resources.
sources/Experiments/CornellBox/Passes/Pass.cs	Adds shared pass lifecycle and sizing.
sources/Experiments/CornellBox/Passes/DenoisePass.cs	Adds temporal and à-trous denoising.
sources/Experiments/CornellBox/Models/Vertex.cs	Defines the scene vertex layout.
sources/Experiments/CornellBox/Models/UpscaleMode.cs	Defines upscaling modes.
sources/Experiments/CornellBox/Models/PassArgs.cs	Adds shared render arguments.
sources/Experiments/CornellBox/Models/Material.cs	Defines the material layout.
sources/Experiments/CornellBox/Models/CornellBoxGeometry.cs	Defines CornellBox geometry.
sources/Experiments/CornellBox/Handlers/ImGuiHandler.cs	Refines input and platform bindings.
sources/Experiments/CornellBox/Handlers/CameraHandler.cs	Clarifies input parameters.
sources/Experiments/CornellBox/CornellBox.csproj	References the upscaling extension.
sources/Experiments/CornellBox/Assets/Shaders/Tonemap.slang	Implements compute tone mapping.
sources/Experiments/CornellBox/Assets/Shaders/Rasterization.slang	Removes the obsolete raster shader.
sources/Experiments/CornellBox/Assets/Shaders/PathTracing.slang	Adds ray-traced outputs and guides.
sources/Experiments/CornellBox/Assets/Shaders/Denoise.slang	Implements temporal and à-trous filtering.
sources/Experiments/CornellBox/App.cs	Integrates the new renderer.
sources/Directory.Packages.props	Updates ImageSharp to 4.1.2.

Review details

Suppressed comments (3)

sources/Experiments/CornellBox/Assets/Shaders/Denoise.slang:394

• For background pixels this branch writes Output only when the step is 1. The step-2, step-4, and step-8 ping-pong iterations return without writing their output, so the step-16 resolve reads stale data from the previous frame instead of the current sky color. Copy Input to Output on every iteration, then keep the step-16 resolve.

    if (all(normal.xyz == 0.0))
    {
        // Temporal and the first iteration refresh both ping-pong pixels.
        if (atrous.StepResetCamera.x == 1)
        {

sources/Experiments/CornellBox/Assets/Shaders/PathTracing.slang:323

• The primary ray query is also advanced only once. Since this query does not use an accept-first-hit flag, a single Proceed() cannot finish traversal and can leave CommittedStatus() unset or select an incomplete hit, breaking primary visibility and all subsequent path shading. Loop until traversal completes.

        query.Proceed();

sources/Experiments/CornellBox/Passes/Pass.cs:40

• Renderer.Render calls Resize every frame, but this method always invokes ResizeImpl even when all dimensions are unchanged. That recreates the path-tracing, denoise, and upscaler targets on every frame, clearing temporal history and causing per-frame allocation; return early when the four dimensions already match.

    public void Resize(uint renderWidth, uint renderHeight, uint displayWidth, uint displayHeight)
    {
        RenderWidth = renderWidth;
        RenderHeight = renderHeight;
        DisplayWidth = displayWidth;

• Files reviewed: 46/48 changed files
• Comments generated: 5
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.